Erik Arvidsson (2013-10-22T13:52:46.000Z)
On Tue, Oct 22, 2013 at 9:10 AM, Rick Waldron <waldron.rick at gmail.com> wrote:
>
>
>
> On Tue, Oct 22, 2013 at 6:41 AM, André Bargull <andre.bargull at udo.edu>
> wrote:
>>>
>>> Traceur has:
>>>
>>> function assign(target, source) {
>>>    var props = $getOwnPropertyNames(source);
>>>    var p, length = props.length;
>>>    for (p = 0; p < length; p++) {
>>>      target[props[p]] = source[props[p]];
>>>    }
>>>    return target;
>>> }
>>>
>>> Which is correct.
>>
>>
>> Almost correct ;-)
>
>
> That was copied verbatim:
> https://github.com/google/traceur-compiler/blob/master/src/runtime/runtime.js#L308-L316

I was a bad code reviewer...

https://github.com/google/traceur-compiler/issues/367


> Rick
>
>
> _______________________________________________
> es-discuss mailing list
> es-discuss at mozilla.org
> https://mail.mozilla.org/listinfo/es-discuss
>



-- 
erik
domenic at domenicdenicola.com (2013-10-26T03:22:41.812Z)
On Tue, Oct 22, 2013 at 9:10 AM, Rick Waldron <waldron.rick at gmail.com> wrote:
> That was copied verbatim:
> https://github.com/google/traceur-compiler/blob/master/src/runtime/runtime.js#L308-L316

I was a bad code reviewer...

https://github.com/google/traceur-compiler/issues/367