Object.getOwnPropertyDescriptors still at stage 0
On Mon, Jan 18, 2016 at 6:50 PM, Andrea Giammarchi <andrea.giammarchi at gmail.com> wrote:
Accordingly with this ecma262 stage 0 summary tc39/ecma262/blob/master/stage0.md the (quite long time ago) discussed
Object.getOwnPropertyDescriptorsgist.github.com/WebReflection/9353781 hasn't move a bit from there.However, there are already use cases gist.github.com/WebReflection/9353781#gistcomment-1672863 and it's already available with Babel.
On top of that, the npm package www.npmjs.com/package/object.getownpropertydescriptors has some download, actually surpassing es7-shim repository es-shims/es7-shim#shims
What should be done in order to move this little improvement to a stage 1 situation?
Consider turning your excellent gist into a repository that fulfills the criteria described here: tc39.github.io/process-document See tc39/Array.prototype.includes for a good example.
Thanks Mathias.
Do you (or anyone else) know if that should be filed as a PR to tc39/ecma262 or if it should just be a repository eventually posted in here?
On Mon, Jan 18, 2016 at 8:27 PM, Andrea Giammarchi <andrea.giammarchi at gmail.com> wrote:
Do you (or anyone else) know if that should be filed as a PR to tc39/ecma262 or if it should just be a repository eventually posted in here?
It should be a repository that can eventually move to the tc39 organization if all goes well. Good luck!
Dear all, the current proposal is here WebReflection/Object.getOwnPropertyDescriptors#objectgetownpropertydescriptors-proposal
It has been mostly copied, as suggested, from tc39/Array.prototype.includes
It has a reference implemntation: WebReflection/Object.getOwnPropertyDescriptors/blob/master/reference-implementation/index.js#L12-L68
It has at least one test: WebReflection/Object.getOwnPropertyDescriptors/blob/master/test/built-ins/Object/getOwnPropertyDescriptors/has-accessors.js
I wonder if there is a specific amount of tests I should cover, right now I just cover the fact it works and it does not ignore accessors.
Woudl a test for symbols and one for data descriptors be enough to move forward?
Thanks.
I’ve opened a number of minor, mostly-editorial issues on the proposal.
In general, how much more work you need to do depends on how many stages you and your TC39 champion (who is it, by the way?) plan to advance the proposal at the next meeting. Looking through tc39.github.io/process-document I’d say:
· For stage 1:
o You need to identify your TC39 champion (it should probably be in the document header)
o You need to identify potential cross-cutting concerns. For example, one might be “should there be a Reflect.getOwnPropertyDescriptors”? (to which my answer is no, but it should be included.)
· For stage 2:
o Fix the editorial bugs in the spec text.
· For stage 3:
o Identify designated reviewers and have them sign off.
o Get Brian to sign off.
· For stage 4:
o Write full tests, covering symbols, data descriptors of every variation, accessors of every variation (get, get/set, set), throwing getters, and proxies with throwing and inconsistent getOwnProperty and ownPropertyKeys traps. (The proxies cases might not be necessary.)
From: es-discuss [mailto:es-discuss-bounces at mozilla.org] On Behalf Of Andrea Giammarchi Sent: Wednesday, January 20, 2016 14:50 To: Mathias Bynens <mathiasb at opera.com>
Cc: es-discuss at mozilla.org Subject: Re: Object.getOwnPropertyDescriptors still at stage 0
Dear all, the current proposal is here WebReflection/Object.getOwnPropertyDescriptors#objectgetownpropertydescriptors-proposal
It has been mostly copied, as suggested, from tc39/Array.prototype.includes
It has a reference implemntation: WebReflection/Object.getOwnPropertyDescriptors/blob/master/reference-implementation/index.js#L12-L68
It has at least one test: WebReflection/Object.getOwnPropertyDescriptors/blob/master/test/built-ins/Object/getOwnPropertyDescriptors/has-accessors.js
I wonder if there is a specific amount of tests I should cover, right now I just cover the fact it works and it does not ignore accessors.
Woudl a test for symbols and one for data descriptors be enough to move forward?
Thanks.
On Mon, Jan 18, 2016 at 9:12 PM, Mathias Bynens <mathiasb at opera.com<mailto:mathiasb at opera.com>> wrote:
On Mon, Jan 18, 2016 at 8:27 PM, Andrea Giammarchi <andrea.giammarchi at gmail.com<mailto:andrea.giammarchi at gmail.com>> wrote:
Do you (or anyone else) know if that should be filed as a PR to tc39/ecma262 or if it should just be a repository eventually posted in here?
It should be a repository that can eventually move to the tc39 organization if all goes well. Good luck!
All clear. So, earlier, the TC39 champion was Rick Waldron but if he's ultra busy (he usually is) and somebody else would like to champion this I'd be happy to update the README with a champion reference.
AFAIK Jordan Harband is the one taking care already of the poly in the npm repo so if you (Jordan) will to champion this I'd be happy to add you to the repo and help as I can.
I'll work on the rest of the mentioned problems ASAP.
Best
If Rick is unavailable, and after I've cleared a few other proposals off my plate, I'd be happy to take over as champion.
Closing the loop on this: this proposal is now stage 4, and will be included in ES 2017. tc39/ecma262#582
Polyfill: www.npmjs.com/package/object.getownpropertydescriptors
Accordingly with this ecma262 stage 0 summary tc39/ecma262/blob/master/stage0.md the (quite long time ago) discussed
Object.getOwnPropertyDescriptorsgist.github.com/WebReflection/9353781 hasn't move a bit from there.However, there are already use cases gist.github.com/WebReflection/9353781#gistcomment-1672863 and it's already available with Babel.
On top of that, the npm package www.npmjs.com/package/object.getownpropertydescriptors has some download, actually surpassing es7-shim repository es-shims/es7-shim#shims
What should be done in order to move this little improvement to a stage 1 situation?
Thanks in advance for any sort of answer. Best